Upgrade numpy version requirement to 2.0 #7659
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade numpy version requirement to Summary: 1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0 We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip We had to upgrade to the latest transformers as well (cherry picked from commit a7b5297)
This was referenced Jan 14, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7659
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit f779ad3 with merge base 9069017 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Seems like Arm jobs are broken because tosa serialization library doesn't support numpy2.0 and has a recent bug fix. Let me try to upgrade this for ET. |
digantdesai
added a commit
that referenced
this pull request
Jan 15, 2025
This is to pull in an upstream fix to unblock #7659
digantdesai
added a commit
that referenced
this pull request
Jan 16, 2025
This is to pull in an upstream fix to unblock #7659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade numpy version requirement to 2.0.0
Summary:
1.21 is too old now. For 3.10 or above, we should be able to use 2.0.0
We are already on CoreMLTools 8.1, which is https://github.com/apple/coremltools/blob/8.1/reqs/build.pip
We had to upgrade to the latest transformers as well
Fixes:
#6639
Test Plan (pending)